Fix mutation operators not working in links and code blocks #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
Mpdreamz
requested changes
Jul 23, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Thank you for tackling this!
Should SubstitutionRenderer.Write reuse SubstitutionMutationHelper ?
Mpdreamz
requested changes
Jul 23, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
One more change to ensure we don't needlessly roundtrip already parsed enums
src/Elastic.Markdown/Myst/InlineParsers/Substitution/SubstitutionParser.cs
Outdated
Show resolved
Hide resolved
src/Elastic.Markdown/Myst/InlineParsers/Substitution/SubstitutionMutationHelper.cs
Show resolved
Hide resolved
Mpdreamz
approved these changes
Jul 23, 2025
theletterf
changed the title
Contributor
Author
|
@Mpdreamz Seems like links get subs even when they're inside a subs=false code block (the example in the docs). Checking. |
Contributor
Author
|
OK, I think it's ready now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1605
Also adds tests for mutation operators.